🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

#!/bin/bash
# Description: Check if e2e tests were updated to match new error wording.
rg -n "reserved for admin user IDP|Expected a valid mapping method" tests/e2e/

Keep the IDP error strings aligned with the existing e2e assertions.
ValidateIdpName now returns the name "cluster-admin" is reserved for admin user IDP, and getMappingMethod now says expected a valid mapping method; options are %s. Existing e2e tests still look for The name "cluster-admin" is reserved for admin user IDP and Expected a valid mapping method. Options are [add claim generate lookup], so this wording change will break those checks unless the tests are updated too.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/create/idp/cmd.go` around lines 447 - 461, The IDP validation messages in
ValidateIdpName and getMappingMethod no longer match the existing e2e
assertions, so align the returned error strings with the expected wording.
Update the cluster-admin reserve message in ValidateIdpName and the mapping
method validation message in getMappingMethod to use the same capitalization and
punctuation as the tests, or adjust the corresponding e2e assertions to match
the new strings.

@olucasfreitas seems valid wdyt

#!/bin/bash
rg -n "reserved for admin user IDP|Expected a valid mapping method|expected a valid mapping method" -C2 --iglob '*.go' .

Confirmed: tests/e2e/test_rosacli_idp.go (Lines 514 and 815) still asserts the old wording (Expected a valid mapping method. Options are [...] and The name "cluster-admin" is reserved for admin user IDP), which will break once cmd/create/idp/cmd.go emits the new lower-case strings. This needs to be fixed in one of these files before merging.

@amandahla Confirmed — the e2e tests still expect the old wording:

• tests/e2e/test_rosacli_idp.go Line 514: "Failed to create IDP for cluster '%s': Expected a valid mapping method. Options are [add claim generate lookup]"
• tests/e2e/test_rosacli_idp.go Line 815: Expect(textData).Should(ContainSubstring("The name \"cluster-admin\" is reserved for admin user IDP"))

Since cmd/create/idp/cmd.go now returns:

• "expected a valid mapping method; options are %s" (Line 553)
• "the name \"cluster-admin\" is reserved for admin user IDP" (Line 460)

these e2e assertions will fail unless updated. You'll need to update the two tests/e2e/test_rosacli_idp.go assertions to match the new lower-case wording (or revert the wording change in cmd.go if you prefer to keep the old strings for consistency with e2e expectations).

func (r *StructuredReporter) Errorf(format string, args ...any) error {
	err := fmt.Errorf(format, args...)
	if !PrintError(err) {
		return r.inner.Errorf(format, args...)
	}
	return err
}

func (r *StructuredReporter) Warnf(format string, args ...any) {
	if !PrintWarn(fmt.Errorf(format, args...)) {
		r.inner.Warnf(format, args...)
	}
}

func (r *StructuredReporter) Debugf(format string, args ...any) {
	r.inner.Debugf(format, args...)
}

func (r *StructuredReporter) Infof(format string, args ...any) {
	r.inner.Infof(format, args...)
}

func (r *Object) Debugf(format string, args ...any) {
	if !debug.Enabled() {
		return
	}
	r.Infof(format, args...)
}

func (r *Object) Infof(format string, args ...any) {
	message := fmt.Sprintf(format, args...)
	if color.UseColor() {
		_, _ = fmt.Fprintf(os.Stdout, "%s%s\n", infoColorPrefix, message)
	} else {
		_, _ = fmt.Fprintf(os.Stdout, "%s%s\n", infoPrefix, message)
	}
}

func (r *Object) Warnf(format string, args ...any) {
	message := fmt.Sprintf(format, args...)
	if color.UseColor() {
		_, _ = fmt.Fprintf(os.Stderr, "%s%s\n", warnColorPrefix, message)
	} else {
		_, _ = fmt.Fprintf(os.Stderr, "%s%s\n", warnPrefix, message)
	}
}

func (r *Object) Errorf(format string, args ...any) error {
	message := fmt.Sprintf(format, args...)
	if color.UseColor() {
		_, _ = fmt.Fprintf(os.Stderr, "%s%s\n", errorColorPrefix, message)
	} else {
		_, _ = fmt.Fprintf(os.Stderr, "%s%s\n", errorPrefix, message)
	}
	return errors.New(message)
}